[KPhotoAlbum] 2 patches for KPhotoAlbum

[Matthias Füssel]

Hello list,

I have two small patches for KPhotoAlbum:

* Fix-Remove-Tokens-dialog.patch:

On KDE 5 in current KPhotoAlbum master, the "Remove Tokens" dialog shows
nothing but the "Ok"/"Cancel" button bar. With this fix it works again.
The fix also adds an ellipsis to the "Remove Tokens" menu entry, suggesting
that it will show a dialog before doing anything and so making it appear far
less scary...

* InfoBox-Add-OpenStreetMap-link-for-images-with-geo-l.patch

For geo-located images, this fix adds a "Show location" link to the image
info box. That link opens OpenStreetMap in a browser and shows a location
marker at the position the image was taken.

Regards,
Matthias FÃŒssel

[Johannes Zarl-Zierl]

Hi Matthias,

Your timing is unfortunate: we just tagged the 5.1 release.

OTOH, that leaves us with plenty of time to review the patches (and also your
other one) ;-)

Thanks for the patches! I think I should be able to review/merge them on
Thursday or Friday...

Cheers,
Johannes

Post by Matthias Füssel
Hello list,
On KDE 5 in current KPhotoAlbum master, the "Remove Tokens" dialog shows
nothing but the "Ok"/"Cancel" button bar. With this fix it works again.
The fix also adds an ellipsis to the "Remove Tokens" menu entry, suggesting
that it will show a dialog before doing anything and so making it appear far
less scary...
* InfoBox-Add-OpenStreetMap-link-for-images-with-geo-l.patch
For geo-located images, this fix adds a "Show location" link to the image
info box. That link opens OpenStreetMap in a browser and shows a location
marker at the position the image was taken.
Regards,
Matthias Füssel

[Johannes Zarl-Zierl]

Hi Matthias,
Thanks! I've merged the patch and will push it shortly...

Post by Matthias Füssel
* InfoBox-Add-OpenStreetMap-link-for-images-with-geo-l.patch
For geo-located images, this fix adds a "Show location" link to the image
info box. That link opens OpenStreetMap in a browser and shows a location
marker at the position the image was taken.

I'm not saying I won't merge this functionality, but I'll have to ask: why do
you want the external link in addition to the existing map view? I feel that
the map view would be a better place for the external link...

Cheers,
Johannes