[KPhotoAlbum] restructuring video thumbnail generation with ffmpeg

[Andreas Schleth]

Hi!

with friendly help from Tobias, I prepared a patch for video thumbnail
generation with ffmpeg / ffprobe. In my installation it builds and works
for me (TM).

Purpose:

    Some strange videos do not have duration info in the stream data.
These videos produced the length "N/A". Thus, here the duration info is
taken

    from somewhere else and parsed accordingly. Here is one of the
offending videos (a short one): https://my.hidrive.com/lnk/3BrpUFZJ

    Then, "short" videos were marked when *any* of the 10 extraction
processes would produce less than 20 images - this seems strange to me.

    Thus, I moved the markShort-function from ExtractOneVideoFrame.cpp
to VideoLengthExtractor.cpp and call it for videos of less than 0.5 s
length.

    At 24 fps this would mean: less 12 frames or less is "short".

I hope, this patch does not break the mplayer functionality. I do not
have mplayer. Please, could someone test this against mplayer?

I will be a.f.k. for a few days - so discussions next week...

Cheers, Andreas

PS:  I found two conventions for writing the {}-clauses:

a) (my preference)

    if (...) {

        do something

    } else {

        whatever

    }

b)

    if (...)

    {

        do something

    }

Which one is the preferred one in KPA?

[Tobias Leupold]

Post by Andreas Schleth
a) (my preference)
if (...) {
do something
} else {
whatever
}
b)
if (...)
{
do something
}
Which one is the preferred one in KPA?

I think we try to stick to the kdelibs coding style:
https://community.kde.org/Policies/Kdelibs_Coding_Style