Discussion:
[KPhotoAlbum] Patch to accept index.xml file with some default data
Robert Krawitz
2018-05-12 02:58:28 UTC
Permalink
These two patches:

1) Accept an index.xml file with missing data assigned default values:

- Label defaults to the basename of the file name
- Angle defaults to 0
- End date defaults to start date

2) Writes an index.xml file with that data omitted if the default
values are correct.

This yields about a 22.5% reduction in the size of my compact-format
index.xml file (from 65675111 to 50905302 bytes).

I'm offering these patches more for purpose of discussion than for
actually being integrated. Patch 1 is fully compatible, but patch 2
obviously is only forward compatible.

As for another problem I had, where I needed to change the name of the
database driver from QSQLITE to QSQLITE3, that issue seems to have
gone away. I assume it was a mixup with the Qt packages from my
distro.
--
Robert Krawitz <***@alum.mit.edu>

*** MIT Engineers A Proud Tradition http://mitathletics.com ***
Member of the League for Programming Freedom -- http://ProgFree.org
Project lead for Gutenprint -- http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
Johannes Zarl-Zierl
2018-05-18 20:33:29 UTC
Permalink
Hi Robert,
Post by Robert Krawitz
I'm offering these patches more for purpose of discussion than for
actually being integrated. Patch 1 is fully compatible, but patch 2
obviously is only forward compatible.
I'm open to both of the patches (although patch 2 obviously needs to increment
the index.xml version as well...).

Cheers,
Johannes

Loading...