[KPhotoAlbum] Regression with .kim import

[Andreas Schleth]

Hi everybody,

did anyone touch the import facilities?

Tested in Version v5.1-17-ga3ff1ef (and in v5.1-8-g518f050): import from
kim fails with "invalid URL" - see attachment.

The import fails with the first image and after creating folders. The
source image is there right besides the *.kim file. Import fails also in
the Demo DB with all import settings on default (no folder generation
...). The .kim file looks quite OK: standard index.xml data after some
random PKzip header bytes.

My guesswork: The error lies probably in the double "//" or the missing
"file://" URL-prefix or the case that this is a URL anyway (do files get
treated as URLs?).

Happy hacking, Andreas

[Johannes Zarl-Zierl]

Hi Andreas,

Post by Andreas Schleth
did anyone touch the import facilities?

Other than porting it to Qt5? No.

I just tried the test .kim files from the git repo, and there was no problem.
These .kim files don't contain a directory, though.
(Note to self: add a testcase using directories)

Post by Andreas Schleth
Tested in Version v5.1-17-ga3ff1ef (and in v5.1-8-g518f050): import from
kim fails with "invalid URL" - see attachment.

Is the path shown in the screenshot valid?

Post by Andreas Schleth
My guesswork: The error lies probably in the double "//" or the missing
"file://" URL-prefix or the case that this is a URL anyway (do files get
treated as URLs?).

The double slash should not be a problem. The missing protocol specification
*may* be a problem, depending on how the QUrl is created.

Strange thing: I didn't find an error message that looks like the one in your
screenshot (I searched for the string "invalid").

Cheers,
Johannes

[Johannes Zarl-Zierl]

Hi Andreas,

Post by Johannes Zarl-Zierl
Is the path shown in the screenshot valid?

Yes, it is the target path (where the image should end up enventually).

Thanks.

The images were originally in the same folder as the *.kim.

It seems that this was the info I was missing. None of the test cases used the
"copy image besides the .kim file" option when exporting.
I can reproduce the problem using the .kim file attached.

Btw this .kim file does not work with KPA 4.7.2 either. It seems that the
problem was introduced before the KF/Qt5 port.

Cheers,
Johannes

[Johannes Zarl-Zierl]

Hi Andreas,

The issue should be fixed in latest git master.

Cheers,
Johannes

Post by Johannes Zarl-Zierl
Hi Andreas,

Post by Johannes Zarl-Zierl
Is the path shown in the screenshot valid?

Yes, it is the target path (where the image should end up enventually).

Thanks.

The images were originally in the same folder as the *.kim.

It seems that this was the info I was missing. None of the test cases used
the "copy image besides the .kim file" option when exporting.
I can reproduce the problem using the .kim file attached.
Btw this .kim file does not work with KPA 4.7.2 either. It seems that the
problem was introduced before the KF/Qt5 port.
Cheers,
Johannes

[Andreas Schleth]

Hi Johannes,

it is - I just tried it out. And we have a new testcase.

Very nice, Andreas



-------- Forwarded Message --------
Subject: [KPhotoAlbum] [FIXED] Re: Regression with .kim import
Date: Sat, 07 Jan 2017 04:08:32 +0100
From: Johannes Zarl-Zierl <***@zarl-zierl.at>
To: ***@mail.kdab.com



Hi Andreas,

The issue should be fixed in latest git master.

Cheers,
Johannes

Post by Johannes Zarl-Zierl
Hi Andreas,

Post by Johannes Zarl-Zierl
Is the path shown in the screenshot valid?

Yes, it is the target path (where the image should end up enventually).

Thanks.

The images were originally in the same folder as the *.kim.

It seems that this was the info I was missing. None of the test cases used
the "copy image besides the .kim file" option when exporting.
I can reproduce the problem using the .kim file attached.
Btw this .kim file does not work with KPA 4.7.2 either. It seems that the
problem was introduced before the KF/Qt5 port.
Cheers,
Johannes