I wasn't aware that my patch was accepted (and maybe it isn't)...
I was planning to rework the patches (not the code for now) but some other projects take all my time 😞
Post by Johannes Zarl-ZierlPost by Robert KrawitzThere's also the startup-performance branch (which I just spotted a
very minor bug that I'm fixing in the MD5 stuff).
Yes, I'm aware - I'll get to it asap (and then there's two other patchsets,
too: Samuel Kay has a new HTML export, and Andreas Neustifter had an
improvement to video-thumbnail creation IIRC).
Post by Robert KrawitzPost by Johannes Zarl-ZierlFor the record, two minor issues remain that need fixing before the
next release: (1) there's an unused member variable creating a
warning message
Where's the warning? I don't see it in the log.
DB/ImageScout.cpp:74:9: warning: private field 'm_index' is not used [-
Wunused-private-field]
int m_index;
Post by Robert KrawitzPost by Johannes Zarl-Zierl(2) the implemenation of OptimizedFileList should be made less linux-specific
Yes, statvfs would be a better option here. Unfortunately, statfs is
much less standardized than stat.
It seems like you know your C library functions and syscalls better than me.
Do you have time to improve cross-platform compatibility here?
As far as I'm concerned, Linux and (Free)BSD should both be supported equally,
if possible. Having a fallback that's possibly slower, but platform-agnostic
is also great.(*)
Cheers,
Johannes
(*) Regarding other platforms: Many(?) KDE applications also support Windows,
but I don't have a build environment for that and as long as nobody pops up
and wants to make a Windows port happen, I'm not investing my limited time
into this. (I'll accept patches, though) I've also heard there's some people
building for MacOs - the same rationale applies here.
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum