[KPhotoAlbum] kphotoalbum git not compiling

[Reimar Imhof]

Hi,
I'm trying to compile latest kphotoalbum from git repository - but I get an
compile error:

[ 57%] Building CXX object CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp: In member function
‘KGeoMap::GeoCoordinates DB::ImageInfo::coordinates() const’:
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:773:48: error: ‘class
Exif::Database’ has no member named ‘readFields’
bool foundIt = Exif::Database::instance()->readFields( m_fileName, fields
);
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:778:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
if ( foundIt && fields[EXIF_GPS_VERSIONID]->value().isNull() )
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:784:37: error: ‘class
Exif::Database’ has no member named ‘readFields’
Exif::Database::instance()->readFields( m_fileName, fields );
^
In file included from /usr/include/QtCore/qchar.h:45:0,
from /usr/include/QtCore/qstring.h:45,
from /home/ri/projects/kphotoalbum.git/DB/ImageInfo.h:22,
from /home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:19:
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:785:48: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
Q_ASSERT( !fields[EXIF_GPS_VERSIONID]->value().isNull() );
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:792:43: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
if ( foundIt && fields[EXIF_GPS_LAT]->value().toInt() != -1.0
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:793:35: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
&& fields[EXIF_GPS_LON]->value().toInt() != -1.0 )
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:796:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double latr = (fields[EXIF_GPS_LATREF]->value().toString() == S ) ?
-1.0 : 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:797:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lat = fields[EXIF_GPS_LAT]->value().toFloat();
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:798:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lonr = (fields[EXIF_GPS_LONREF]->value().toString() == W ) ?
-1.0 : 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:799:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lon = fields[EXIF_GPS_LON]->value().toFloat();
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:800:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double altr = (fields[EXIF_GPS_ALTREF]->value().toInt() == 1 ) ? -1.0
: 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:801:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double alt = fields[EXIF_GPS_ALT]->value().toFloat();
^
CMakeFiles/kphotoalbum.dir/build.make:2612: recipe for target
'CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o' failed
make[2]: *** [CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:162: recipe for target 'CMakeFiles/kphotoalbum.dir/all'
failed
make[1]: *** [CMakeFiles/kphotoalbum.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
*** Fehler: Beendigungscode 2 ***

There is no problem to compile kphotoalbum 4.7 from
http://download.kde.org/stable/kphotoalbum/4.7/src/kphotoalbum-4.7.tar.xz

System is openSuse 13.2, kde 4.14.9
Any ideas?

Thanks
Reimar

[Tobias Leupold]

Hi :-)

Post by Reimar Imhof
I'm trying to compile latest kphotoalbum from git repository - but I get an
compile error

With current git master, I also get compile errors when compiling
DB/ImageInfo.cpp, starting with Exif::Database not having readFields.

Apparently, Johannes was working on quite some code the last few days and this
seems to be a regression. I'm sure he will fix it as soon as possible.

The "Media Type" bug is probably really due to the category l10n removal.
Thanks for the hint! I never had a look into this category before, so I didn't
notice this one. Should be not so hard to fix. I'll have a look at it as soon
as I can, and/or as soon as git master compiles again ;-)

Cheers, Tobias

[Reimar Imhof]

Hi Johannes,

thanks for the fixes.

Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of folder
and media type c…".

While you were building it I had a try on my own.
Strange: My change is quite similar to your one but I didn't know anything
about "categoryForSpecial(DB::Category::FolderCategory)" -
I just put "categoryForName(i18n("Folder"))" in all places.
Now I got a strange behavior: When adding new folders to my kphotoalbum root
folder (and start kphotoalbum) there names show up when using my (simpler)
patch.
When I'm using your patch I just get a new folder called "unknown".
I've to save the database and restart kphotoalbum to get the correct name.
That problem even shows up when using C locale.

Perhaps you could have a look at this:
Put a new folder with some photos to your kphotoalbum folder and start
kphotoalbum and go to the folder category - the folder just shows up without
it's name...

Cheers, Reimar

Post by Tobias Leupold
Hi :-)

Post by Reimar Imhof
I'm trying to compile latest kphotoalbum from git repository - but I get an
compile error

With current git master, I also get compile errors when compiling
DB/ImageInfo.cpp, starting with Exif::Database not having readFields.
Apparently, Johannes was working on quite some code the last few days and
this seems to be a regression. I'm sure he will fix it as soon as possible.
The "Media Type" bug is probably really due to the category l10n removal.
Thanks for the hint! I never had a look into this category before, so I
didn't notice this one. Should be not so hard to fix. I'll have a look at
it as soon as I can, and/or as soon as git master compiles again ;-)
Cheers, Tobias
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Johannes Zarl-Zierl]

Hi Reimar,

Post by Reimar Imhof
Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of folder
and media type c…".

I should have pushed these to a different branch, as they were not a full fix
for the problem, yet. I had just done a quick push so that Tobias could test
the changes. Sorry for the confusion.

Post by Reimar Imhof
When I'm using your patch I just get a new folder called "unknown".
I've to save the database and restart kphotoalbum to get the correct name.
That problem even shows up when using C locale.
Put a new folder with some photos to your kphotoalbum folder and start
kphotoalbum and go to the folder category - the folder just shows up without
it's name...

Ah, yes, that was caused by an incorrect initialization of the special
categories. This issue should be fixed now.

Cheers,
Johannes

[Reimar Imhof]

Hi Johannes, hi Tobias,

thanks for the new patch.

I applied both patches (35d4a6d and 10421fc) at kphotoalbum 4.7 and it's much
better now.
Your patch is better then my "simple" patch because it needs less strings
(like "Folder" or "Media Type") but uses enum like
DB::Category::FolderCategory.

There still is a smaller i18n issue, my patch didn't solve and your one
doesn't solve either :-(
- Start kphotoalbum
- Select "Media Type" (in German "Medientyp")
- You get a table with media types "Image" and "Video" in the left column;
well it should be "Bild" and "Video" (if you use German locale).
I reinstalled to old kphotoalbum 4.6.2 just for a test. It showed the
translated items ("Bild"/"Video") as expected.
Sorry, I've no idea where to look for a fix. I searched for all occurrences of
"Video" but couldn't find anything related to the missing translation.

What about having a 4.7.0.1 (or how ever you want to call it) after these
problems are fixed?

Cheers, Reimar

Post by Johannes Zarl-Zierl
Hi Reimar,

Post by Reimar Imhof
Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of
folder and media type c…".

I should have pushed these to a different branch, as they were not a full
fix for the problem, yet. I had just done a quick push so that Tobias could
test the changes. Sorry for the confusion.

Post by Reimar Imhof
When I'm using your patch I just get a new folder called "unknown".
I've to save the database and restart kphotoalbum to get the correct name.
That problem even shows up when using C locale.
Put a new folder with some photos to your kphotoalbum folder and start
kphotoalbum and go to the folder category - the folder just shows up
without it's name...

Ah, yes, that was caused by an incorrect initialization of the special
categories. This issue should be fixed now.
Cheers,
Johannes
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Reimar Imhof]

Hi,

here comes the next patch.
It's needed to prevent the geolocation plugin from crashing (and make
kphotoalbum crash as well).

It's just an other i18n replacement.

Please have a look at the patch and put it to git (or put a better version to
git).

Thanks a lot, Reimar

Post by Johannes Zarl-Zierl
Hi Reimar,

Post by Reimar Imhof
Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of
folder and media type c
".

I should have pushed these to a different branch, as they were not a full
fix for the problem, yet. I had just done a quick push so that Tobias could
test the changes. Sorry for the confusion.

Post by Reimar Imhof
When I'm using your patch I just get a new folder called "unknown".
I've to save the database and restart kphotoalbum to get the correct name.
That problem even shows up when using C locale.
Put a new folder with some photos to your kphotoalbum folder and start
kphotoalbum and go to the folder category - the folder just shows up
without it's name...

Ah, yes, that was caused by an incorrect initialization of the special
categories. This issue should be fixed now.
Cheers,
Johannes
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Reimar Imhof]

Hi again,

here comes version two of yesterday's patch:
I've changed to category from i18n("Places") to i18n("Folder") because
"Folder" is automatically generated and is always there. A translated places
may be available but perhaps it's not.
For example the kphotoalbum demo is working with the new patch (I can start
the geo tagging plugin), even though there is no translated "places" but an
English places. Trying to start the plugin with the old patch crashed
kphotoalbum because of a missing category "Orte" (I was using German local).

Cheers, Reimar

Post by Reimar Imhof
Hi,
here comes the next patch.
It's needed to prevent the geolocation plugin from crashing (and make
kphotoalbum crash as well).
It's just an other i18n replacement.
Please have a look at the patch and put it to git (or put a better version
to git).
Thanks a lot, Reimar

Post by Johannes Zarl-Zierl
Hi Reimar,

Post by Reimar Imhof
Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of
folder and media type c
".

I should have pushed these to a different branch, as they were not a full
fix for the problem, yet. I had just done a quick push so that Tobias could
test the changes. Sorry for the confusion.

Post by Reimar Imhof
When I'm using your patch I just get a new folder called "unknown".
I've to save the database and restart kphotoalbum to get the correct name.
That problem even shows up when using C locale.
Put a new folder with some photos to your kphotoalbum folder and start
kphotoalbum and go to the folder category - the folder just shows up
without it's name...

Ah, yes, that was caused by an incorrect initialization of the special
categories. This issue should be fixed now.
Cheers,
Johannes
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Tobias Leupold]

Hi Reimar!

Thanks for the patch! But apart from the fact that I can actually reproduce
this crash: how can this even happen? How can a KIPI plugin crash KPA due to a
category being there or not? Do the KIPI plugins even know about KPA's
categories?

What does this Plugins::Interface::getTagTree() do? If it does not really
affect anything, should we probably better use some dummy data?

I would really appreciate if somebody could clarify this to a KIPI-n00b ;-)

Cheers, Tobias

[Reimar Imhof]

Hi Tobias,

sorry, I've not a clue.

I've just read the comment in the method and wanted to avoid the crash since
I'm using that plugin.

Cheers, Reimar

Post by Tobias Leupold
Hi Reimar!
Thanks for the patch! But apart from the fact that I can actually reproduce
this crash: how can this even happen? How can a KIPI plugin crash KPA due to
a category being there or not? Do the KIPI plugins even know about KPA's
categories?
What does this Plugins::Interface::getTagTree() do? If it does not really
affect anything, should we probably better use some dummy data?
I would really appreciate if somebody could clarify this to a KIPI-n00b ;-)
Cheers, Tobias
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Reimar Imhof]

Hi Johannes,

I'll give it a try soon.

Cheers,
Reimar

Post by Johannes Zarl-Zierl
Hi Reimar,
Sorry for not getting back to you sooner.
http://commits.kde.org/kphotoalbum/780aa1498ed333254c886aacba1195f703e9de15
This way, you should get the correct category (Places) by default, and a
save fall-back when you're using a different locale (or if you removed the
localized "Places" category).
I currently don't have a working geolocation-plugin installed - can you
please verify that the fix is working for you?
Cheers,
Johannes

[Reimar Imhof]

Hi Johannes,

I took the new version 4.7.1.
(btw: Is there an announcement and a download link coming along??)
Geolocation plugin comes up using that version.

I've tried with german and with C lokale.

Thanks!

Cheers
Reimar

Post by Reimar Imhof
Hi Johannes,
I'll give it a try soon.
Cheers,
Reimar

Post by Johannes Zarl-Zierl
Hi Reimar,
Sorry for not getting back to you sooner.
http://commits.kde.org/kphotoalbum/780aa1498ed333254c886aacba1195f703e9de1
5
This way, you should get the correct category (Places) by default, and a
save fall-back when you're using a different locale (or if you removed the
localized "Places" category).
I currently don't have a working geolocation-plugin installed - can you
please verify that the fix is working for you?
Cheers,
Johannes

_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Johannes Zarl-Zierl]

Hi Reimar,

Post by Reimar Imhof
I took the new version 4.7.1.
(btw: Is there an announcement and a download link coming along??)

Yes - Tobias just wanted to wait with the announcement until all mirrors got
the file...

Post by Reimar Imhof
Geolocation plugin comes up using that version.
I've tried with german and with C lokale.

Great. Thanks for checking!

Cheers,
Johannes

[Tobias Leupold]

I'll do the official announcement and update the homepage tomorrow or by no
later than this weekend – no spare time due to my construction site ;-)

Post by Johannes Zarl-Zierl
Hi Reimar,

Post by Reimar Imhof
I took the new version 4.7.1.
(btw: Is there an announcement and a download link coming along??)

Yes - Tobias just wanted to wait with the announcement until all mirrors got
the file...

Post by Reimar Imhof
Geolocation plugin comes up using that version.
I've tried with german and with C lokale.

Great. Thanks for checking!
Cheers,
Johannes
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

[Johannes Zarl-Zierl]

Hi,

The compile error was indeed introduced by my not testing with all features
enabled. It is fixed in 6b0af6e.

Thanks for pointing out the problem!

Johannes

Post by Reimar Imhof
Hi,
I'm trying to compile latest kphotoalbum from git repository - but I get an
[ 57%] Building CXX object CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp: In member function
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:773:48: error: ‘class
Exif::Database’ has no member named ‘readFields’
bool foundIt = Exif::Database::instance()->readFields( m_fileName,
fields );
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:778:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
if ( foundIt && fields[EXIF_GPS_VERSIONID]->value().isNull() )
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:784:37: error: ‘class
Exif::Database’ has no member named ‘readFields’
Exif::Database::instance()->readFields( m_fileName, fields );
^
In file included from /usr/include/QtCore/qchar.h:45:0,
from /usr/include/QtCore/qstring.h:45,
from /home/ri/projects/kphotoalbum.git/DB/ImageInfo.h:22,
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:785:48: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
Q_ASSERT( !fields[EXIF_GPS_VERSIONID]->value().isNull() );
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:792:43: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
if ( foundIt && fields[EXIF_GPS_LAT]->value().toInt() != -1.0
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:793:35: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
&& fields[EXIF_GPS_LON]->value().toInt() != -1.0 )
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:796:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double latr = (fields[EXIF_GPS_LATREF]->value().toString() == S ) ?
-1.0 : 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:797:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lat = fields[EXIF_GPS_LAT]->value().toFloat();
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:798:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lonr = (fields[EXIF_GPS_LONREF]->value().toString() == W ) ?
-1.0 : 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:799:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double lon = fields[EXIF_GPS_LON]->value().toFloat();
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:800:49: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double altr = (fields[EXIF_GPS_ALTREF]->value().toInt() == 1 ) ? -1.0
: 1.0;
^
/home/ri/projects/kphotoalbum.git/DB/ImageInfo.cpp:801:44: error: ‘class
Exif::DatabaseElement’ has no member named ‘value’
double alt = fields[EXIF_GPS_ALT]->value().toFloat();
^
CMakeFiles/kphotoalbum.dir/build.make:2612: recipe for target
'CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o' failed
make[2]: *** [CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
CMakeFiles/Makefile2:162: recipe for target 'CMakeFiles/kphotoalbum.dir/all'
failed
make[1]: *** [CMakeFiles/kphotoalbum.dir/all] Error 2
Makefile:127: recipe for target 'all' failed
make: *** [all] Error 2
*** Fehler: Beendigungscode 2 ***
There is no problem to compile kphotoalbum 4.7 from
http://download.kde.org/stable/kphotoalbum/4.7/src/kphotoalbum-4.7.tar.xz
System is openSuse 13.2, kde 4.14.9
Any ideas?
Thanks
Reimar
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum