[KPhotoAlbum] Crash with the latest git in find new images

[Robert Krawitz]

It's crashing in the event stuff. Unfortunately, I can't conveniently
install the debuginfo packages right now.

[Johannes Zarl-Zierl]

Hi Robert,

Interesting - I tried it with a big (~1300 images) import with no issues.

Thinking about it, I moved the video length detection into the LoadExtraFile method. That code was previously dead along with the markUntagged call, so maybe there's some threading issue going on there...

Cheers,
Johannes

Post by Robert Krawitz
It's crashing in the event stuff. Unfortunately, I can't conveniently
install the debuginfo packages right now.

[Robert Krawitz]

Post by Johannes Zarl-Zierl
Hi Robert,
Interesting - I tried it with a big (~1300 images) import with no issues.
Thinking about it, I moved the video length detection into the
LoadExtraFile method. That code was previously dead along with the
markUntagged call, so maybe there's some threading issue going on
there...

I don't have any videos in my import, in case it matters. I do have a
mixture of RAW and JPEG files.

[Johannes Zarl-Zierl]

Post by Robert Krawitz
I don't have any videos in my import, in case it matters. I do have a
mixture of RAW and JPEG files.

Ok then. Any pointers as to where the crash happens? How reproducible is it?

Johannes

[Robert Krawitz]

Post by Johannes Zarl-Zierl

Post by Robert Krawitz
I don't have any videos in my import, in case it matters. I do have a
mixture of RAW and JPEG files.

Ok then. Any pointers as to where the crash happens? How reproducible is it?

It was 100% reproducible before I read the most recent batch of files.
It happens when the searching for new files message is visible in the
splash screen but before the image loading bos shows up. The stack
trace I see now looks more reasonable.

Note that buildOneThumbnail() is apparently being called quite early.

[Robert Krawitz]

Post by Johannes Zarl-Zierl

Post by Robert Krawitz
I don't have any videos in my import, in case it matters. I do have a
mixture of RAW and JPEG files.

Ok then. Any pointers as to where the crash happens? How reproducible is it?

The issue happens when autostack is enabled, and we're loading the
second image of a stack.

Note that line 631 of NewImageFinder.cpp:

info = nullptr;

but then later on info (which is now a null pointer) is used.

Over to you.

[Johannes Zarl-Zierl]

Post by Robert Krawitz
The issue happens when autostack is enabled, and we're loading the
second image of a stack.
info = nullptr;
but then later on info (which is now a null pointer) is used.
Over to you.

D'oh! Moving that line around will have that effect :-|

Sorry - I'll fix it tomorrow...

Thanks!
Johannes

[Johannes Zarl-Zierl]

Post by Johannes Zarl-Zierl
Sorry - I'll fix it tomorrow...

Done. On the plus side, the way the LoadExtraFile(s) methods interact is a
little saner now...

Cheers,
Johannes