[KPhotoAlbum] kf5-port: fix for crash when clicking on browse items

[Matthias Füssel]

Hello @all,

I've played a bit with the "kf5-port" branch under openSuSE Tumbleweed (KDE
5). It compiles fine but crashes whenever you click on some category icon or
tag icon in the browse view (crash happens during mouseRelease event, using
the keyboard works).

If you connect the "itemClicked" slot with the "activated" signal instead of
the "clicked" signal (see attached diff), clicking cateories and tags works
again. You also get the "selected item will be triggered when the return key
is pressed" behaviour for free (i.e. without the code in the event filter) if
you use "activated".

After this fix, at first glance most of KPhotoAlbum seems to work with KDE5/KF5.

Regards,
Matthias

[Johannes Zarl-Zierl]

Hi Matthias,

Thanks for sending the patch (even more so since I don't have much time for
the port currently)! I've pushed it to the kf5-port branch...

Cheers,
Johannes

Post by Matthias Füssel
I've played a bit with the "kf5-port" branch under openSuSE Tumbleweed (KDE
5). It compiles fine but crashes whenever you click on some category icon or
tag icon in the browse view (crash happens during mouseRelease event, using
the keyboard works).
If you connect the "itemClicked" slot with the "activated" signal instead of
the "clicked" signal (see attached diff), clicking cateories and tags works
again. You also get the "selected item will be triggered when the return
key is pressed" behaviour for free (i.e. without the code in the event
filter) if you use "activated".
After this fix, at first glance most of KPhotoAlbum seems to work with KDE5/KF5.
Regards,
Matthias