Discussion:
[KPhotoAlbum] search-performance branch
Robert Krawitz
2018-10-28 04:43:10 UTC
Permalink
It looks like the other fixes I did improved matters considerably for
date search. However, I did find some more inefficiency in the match
code, most notably in not immediately returning on a failed test. The
date comparison code was also needlessly complicated -- all that's
really needed is to check whether the image start date is greater than
the search end date or the image end date is less than the search
start.

I've pushed those changes to the search-performance branch (and merged
that up to the current master).
--
Robert Krawitz <***@alum.mit.edu>

*** MIT Engineers A Proud Tradition http://mitathletics.com ***
Member of the League for Programming Freedom -- http://ProgFree.org
Project lead for Gutenprint -- http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
Robert Krawitz
2018-10-28 17:28:42 UTC
Permalink
Post by Robert Krawitz
really needed is to check whether the image start date is greater than
the search end date or the image end date is less than the search
start.
Yes, then the image is "out", isn't it?
I hope there is a sanity check that start date <= end date for both
search and image.
I notied that; I'm moving those checks to the constructors for
ImageDate.
--
Robert Krawitz <***@alum.mit.edu>

*** MIT Engineers A Proud Tradition http://mitathletics.com ***
Member of the League for Programming Freedom -- http://ProgFree.org
Project lead for Gutenprint -- http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton
Johannes Zarl-Zierl
2018-10-28 18:47:37 UTC
Permalink
Hi Robert,

If you think the search-performance branch is ready, you can merge it with
master any time...

Cheers,
Johannes
Post by Robert Krawitz
Post by Robert Krawitz
really needed is to check whether the image start date is greater than
the search end date or the image end date is less than the search
start.
Yes, then the image is "out", isn't it?
I hope there is a sanity check that start date <= end date for both
search and image.
I notied that; I'm moving those checks to the constructors for
ImageDate.
Samuel Kay
2018-11-01 22:03:17 UTC
Permalink
_______________________________________________
KPhotoAlbum mailing list
***@mail.kdab.com
https://mail.kdab.com/mailman/listinfo/kphotoalbum
Johannes Zarl-Zierl
2018-11-02 09:59:13 UTC
Permalink
Hello Samuel,

Sorry for top-posting - I'm away from my computer for the weekend and my phone does not do proper replies.

Thanks for reporting the issues! Having a patch is always welcome, but certainly not required ;-)

As for the code issues: the preferred thing to do (from my perspective) is to file a big report. This makes it easy for others to find the report and to comment on it (if they are not already subscribed to the mailing list).

Cheers,
Johannes
Post by Samuel Kay
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum
Loading...