[KPhotoAlbum] error compiling in Ubuntu 16.04 and Mint 18.3

[Andreas Schleth]

Hi everybody,

when I try to build KPA from git master in those two systems, make fails
with this error:

/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp: In member function ‘bool
DB::ImageInfo::hasCategoryInfo(const QString&, const StringSet&) const’:
/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp:130:19: error: ‘const
StringSet {aka const class QSet<QString>}’ has no member named ‘intersects’
     return values.intersects( m_categoryInfomation[key] );
                   ^
CMakeFiles/kphotoalbum.dir/build.make:2534: die Regel für Ziel
„CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o“ scheiterte

It builds nicely in openSuSE Leap 42.2. The main difference seems to be
the version of gcc:

opensuse: gcc (SUSE Linux) 4.8.5

ubuntu 16.04 (and Mint): gcc (Ubuntu 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609

Any ideas?

Andreas

[Johannes Zarl-Zierl]

Hi Andreas,

The relevant difference is the version of Qt: OpenSUSE leap 42.1 still has Qt
5.5 (leap 42.2 and Mint 18.3 probably as well).

I've patched KPA to compile with Qt 5.5 again (we already have similar patches
in a few places).

Since you have probably more experience with OpenSUSE leap than me: Do you
know which version of leap introduces a newer Qt version?
For now, supporting Qt 5.5 does not pose a problem, but eventually it might
become a burden...

Cheers,
Johannes

Post by Andreas Schleth
Hi everybody,
when I try to build KPA from git master in those two systems, make fails
/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp: In member function ‘bool
/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp:130:19: error: ‘const
StringSet {aka const class QSet<QString>}’ has no member named ‘intersects’
return values.intersects( m_categoryInfomation[key] );
^
CMakeFiles/kphotoalbum.dir/build.make:2534: die Regel für Ziel
„CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o“ scheiterte
It builds nicely in openSuSE Leap 42.2. The main difference seems to be
opensuse: gcc (SUSE Linux) 4.8.5
ubuntu 16.04 (and Mint): gcc (Ubuntu 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609
Any ideas?
Andreas
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

...

[Robert Krawitz]

Post by Johannes Zarl-Zierl
Hi Andreas,
The relevant difference is the version of Qt: OpenSUSE leap 42.1 still has Qt 5.5 (leap 42.2 and Mint 18.3 probably as well).
I've patched KPA to compile with Qt 5.5 again (we already have similar patches in a few places).
Since you have probably more experience with OpenSUSE leap than me: Do you know which version of leap introduces a newer Qt version?
For now, supporting Qt 5.5 does not pose a problem, but eventually it might become a burden...

42.1 is outside of its support window, IIRC.

42.2 uses Qt 5.6.

Post by Johannes Zarl-Zierl

Post by Andreas Schleth
Hi everybody,
when I try to build KPA from git master in those two systems, make fails
/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp: In member function ‘bool
/home/as/kpa/kphotoalbum/DB/ImageInfo.cpp:130:19: error: ‘const
StringSet {aka const class QSet<QString>}’ has no member named ‘intersects’
return values.intersects( m_categoryInfomation[key] );
^
CMakeFiles/kphotoalbum.dir/build.make:2534: die Regel für Ziel
„CMakeFiles/kphotoalbum.dir/DB/ImageInfo.cpp.o“ scheiterte
It builds nicely in openSuSE Leap 42.2. The main difference seems to be
opensuse: gcc (SUSE Linux) 4.8.5
ubuntu 16.04 (and Mint): gcc (Ubuntu 5.4.0-6ubuntu1~16.04.5) 5.4.0 20160609
Any ideas?

...

[Johannes Zarl-Zierl]

[sending again, this time to the list address]

Hi Robert,

Post by Robert Krawitz

Post by Johannes Zarl-Zierl
The relevant difference is the version of Qt: OpenSUSE leap 42.1 still has
Qt 5.5 (leap 42.2 and Mint 18.3 probably as well).

42.1 is outside of its support window, IIRC.
42.2 uses Qt 5.6.

I seem to have misread the original mail. Thanks for pointing this out.

I've now read up on Linux Mint: 18.3 is the latest version - how can this
still use Qt 5.5? Am I missing something there?

Cheers,
Johannes

[Andreas Schleth]

Hi Johannes,

here are the revisions:

opensuse 42.2: KDE 5.26 / QT 5.6.1 - compiles and looks good
Ubuntu 16.04 / Linux Mint 18.3: KDE 5.18.1 / QT 5.5.1 (Mint ships with
KPA 4.7) - compilation of git master fails (last working rev. was 5.1 -
did not show icons)
Ubuntu 17.10 / Kubuntu 17.10: KDE 5.38.0 / QT 5.9.1 (17.10 ships with
KPA 5.2) - icons don't show up in Gnome/Unitiy-Ubuntu but are OK in Kubuntu

As Mint is quite popular and will always be based on a LTS-revision of
Ubuntu, I strongly suggest to have at least the releases compatible with
the latest LTS-Version, even if the libs are a bit outdated. I guess,
Ubuntu LTS + Mint combined will have a relative majority among all Linux
desktops, esp. among more casual users.

KPA has a really good "WAF-Factor" (at least here it makes the top five:
Browser, Mail, Office, PDF-Reader, KPA). So I expect the "casual user"
could be KPAs prime target.

Regards, Andreas

Post by Johannes Zarl-Zierl
[sending again, this time to the list address]
Hi Robert,

Post by Robert Krawitz

Post by Johannes Zarl-Zierl
The relevant difference is the version of Qt: OpenSUSE leap 42.1 still has
Qt 5.5 (leap 42.2 and Mint 18.3 probably as well).

42.1 is outside of its support window, IIRC.
42.2 uses Qt 5.6.

I seem to have misread the original mail. Thanks for pointing this out.
I've now read up on Linux Mint: 18.3 is the latest version - how can this
still use Qt 5.5? Am I missing something there?
Cheers,
Johannes
_______________________________________________
KPhotoAlbum mailing list
https://mail.kdab.com/mailman/listinfo/kphotoalbum

...

[Johannes Zarl-Zierl]

Hi Andreas,

Post by Andreas Schleth
opensuse 42.2: KDE 5.26 / QT 5.6.1 - compiles and looks good
Ubuntu 16.04 / Linux Mint 18.3: KDE 5.18.1 / QT 5.5.1 (Mint ships with
KPA 4.7) - compilation of git master fails (last working rev. was 5.1 -
did not show icons)
Ubuntu 17.10 / Kubuntu 17.10: KDE 5.38.0 / QT 5.9.1 (17.10 ships with
KPA 5.2) - icons don't show up in Gnome/Unitiy-Ubuntu but are OK in Kubuntu

Thanks for the research.

Post by Andreas Schleth
As Mint is quite popular and will always be based on a LTS-revision of
Ubuntu, I strongly suggest to have at least the releases compatible with
the latest LTS-Version, even if the libs are a bit outdated. I guess,
Ubuntu LTS + Mint combined will have a relative majority among all Linux
desktops, esp. among more casual users.

From my point of view, supporting the latest Ubuntu LTS plus 3 months or so is
an acceptable trade-off.
I don't want the #ifdef's to pile up without bounds, but so far they are quite
manageable in practice.

Post by Andreas Schleth
Browser, Mail, Office, PDF-Reader, KPA). So I expect the "casual user"
could be KPAs prime target.

I had to google that expression, but I'm glad that KPA is liked by both you
and your wife ;-)

Cheers,
Johannes